Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows support for Malicious website protection #1423

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Windows support for Malicious website protection #1423

wants to merge 1 commit into from

Conversation

mgurgel
Copy link
Contributor

@mgurgel mgurgel commented Jan 23, 2025 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/0/72649045549333/1208745889841029/f

Description

Malicious site Special Error page for Windows

Previews:

Figma

Testing Steps

  • In the web preview, check that all styles match Figma, including when Advanced button is clicked
  • In native build, check that all buttons work

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@netlify Netlify
Copy link

netlify bot commented Jan 23, 2025 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 52d7477
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/679a0a586971640008a3670b
😎 Deploy Preview https://deploy-preview-1423--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 23, 2025 •
edited
Loading

[Beta] Generated file diff

Time updated: Wed, 29 Jan 2025 11:01:39 GMT

Integration 
    - integration/pages/release-notes/dist/index.css
  • integration/pages/release-notes/dist/index.js
  • integration/pages/special-error/dist/index.css
  • integration/pages/special-error/dist/index.js
  • integration/pages/special-error/dist/inline.js

File has changed

Apple 
    - dist/pages/release-notes/dist/index.css
  • dist/pages/release-notes/dist/index.js
  • dist/pages/special-error/dist/index.css
  • dist/pages/special-error/dist/index.js
  • dist/pages/special-error/dist/inline.js
  • dist/pages/special-error/index.html

File has changed

New Files 
    - windows/pages/special-error/dist/Malware-Site-96-A35AQOKY.svg
  • windows/pages/special-error/dist/Shield-Alert-128-NGB6TVH6.svg
  • windows/pages/special-error/dist/Shield-Alert-96-W3VSTNOR.svg
  • windows/pages/special-error/dist/index.css
  • windows/pages/special-error/dist/index.js
  • windows/pages/special-error/dist/inline.js
  • windows/pages/special-error/index.html
  • windows/pages/special-error/locales/bg/special-error.json
  • windows/pages/special-error/locales/cs/special-error.json
  • windows/pages/special-error/locales/da/special-error.json
  • windows/pages/special-error/locales/de/special-error.json
  • windows/pages/special-error/locales/el/special-error.json
  • windows/pages/special-error/locales/en/special-error.json
  • windows/pages/special-error/locales/es/special-error.json
  • windows/pages/special-error/locales/et/special-error.json
  • windows/pages/special-error/locales/fi/special-error.json
  • windows/pages/special-error/locales/fr/special-error.json
  • windows/pages/special-error/locales/hr/special-error.json
  • windows/pages/special-error/locales/hu/special-error.json
  • windows/pages/special-error/locales/it/special-error.json
  • windows/pages/special-error/locales/lt/special-error.json
  • windows/pages/special-error/locales/lv/special-error.json
  • windows/pages/special-error/locales/nb/special-error.json
  • windows/pages/special-error/locales/nl/special-error.json
  • windows/pages/special-error/locales/pl/special-error.json
  • windows/pages/special-error/locales/pt/special-error.json
  • windows/pages/special-error/locales/ro/special-error.json
  • windows/pages/special-error/locales/ru/special-error.json
  • windows/pages/special-error/locales/sk/special-error.json
  • windows/pages/special-error/locales/sl/special-error.json
  • windows/pages/special-error/locales/sv/special-error.json
  • windows/pages/special-error/locales/tr/special-error.json

❌ File only exists in new changeset

@mgurgel mgurgel force-pushed the mgurgel/malware-windows branch 3 times, most recently from 1d86929 to 2ec637b Compare January 24, 2025 14:08
@RendijsSmukulis
Copy link
Contributor

Some minor nits:

  • The radius around the frame seems off: (left is implementation, right is Figma):

image

  • The margins/padding for text under "Advanced" seems off:

Impl:
image

Figma:
image

(The latter seems to be an issue when using ?platform=macos as well:
image)

@mgurgel mgurgel marked this pull request as ready for review January 29, 2025 11:00
@mgurgel mgurgel requested review from shakyShane and a team as code owners January 29, 2025 11:00
@mgurgel mgurgel force-pushed the mgurgel/malware-windows branch from 2ec637b to 52d7477 Compare January 29, 2025 11:00
RendijsSmukulis
RendijsSmukulis requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@RendijsSmukulis RendijsSmukulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few UI issues in a comment - namely the radius of the corners, and the padding for the "Advanced Info" not looking right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RendijsSmukulis RendijsSmukulis RendijsSmukulis requested changes

@shakyShane shakyShane Awaiting requested review from shakyShane shakyShane is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgurgel @RendijsSmukulis